Lived there for 2 years 2022-2024. Don't worry about the brolly, it's one of the driest cities in the UK! It is however, windy as fuck.
The city centre will be absolutely rammed and honestly I'd veer away from it. Yes, see the castle and the royal mile but for relaxing times I'd head towards Leith or Bruntsfield/Morningside or Stockbridge depending on where you're staying. There are decent pubs and restaurants in the centre but they're not worth the crowds IMO. Lots of nice independent shops and the like in Stockbridge and Bruntsfield/Morningside
Stroll down Leith Walk towards Leith or Broughton St towards Stockbridge and you'll have a ready made pub crawl with several worthy boozers and restaurants on the way.
For historical things, I really recommend Real Mary King's Close. Actually gives some insight into life in Edinburgh in Ye Olden Times. Avoid the various Whisky tours and basically anything else on the royal mile.
A pal does Walking Tours which have won various awards and seem to be very popular:
https://bobbystoursedinburgh.com/
Personal favourites
Pubs (Centre)
Jolly Judge, old fashioned blokes boozer in an alley of Cockburn St
Bow bar, real ale bar on Victoria St. A good place to nip in to escape the tourists.
Abbotsford and The Guildford Arms both near Waverley
Pubs (elsewhere)
Newbarns, craft beer taproom that's also good for sport, quiz, boardgames.
Other Leith taprooms - Campervan/Pilot/Moonwake
Actually anywhere on the Shore is decent, that used to be my ends. Malt & Hops, Carriers Quarters, Teuchter's Landing.
Eastway Tap on Easter Rd near the Hibs ground
Stockbridge Tap
Restaurants
Noto
Mirin
Cafe St Honore
Chez Jules (great craic, cheap n cheerful french place for steak frites and house wine)
Eleanore
Little Chartroom (michelin prices but extremely good)
Ardfern for a roast
and for the love of God don't go into any Black Sheep Coffee they're a plague.